Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3 #6

Merged
merged 5 commits into from
Jul 7, 2021
Merged

Issue 3 #6

merged 5 commits into from
Jul 7, 2021

Conversation

greebie
Copy link
Contributor

@greebie greebie commented Jun 28, 2021

This is the initial start to #3 . I noticed that ckan uses pytest and the tests are called from ckan itself (which is much better than introducing another library, even if it's a built-in.) The default configuration should trigger the tests to run, although you may want to make sure the ckan tests are called in the pipeline.

Calling for this to be pulled into development, rather than main.

I included some simple tests on the plugin.py and used comments to suggest some changes to the code approach for readability.

@aianta aianta merged commit bc1f030 into development Jul 7, 2021
@JaredMclellan JaredMclellan deleted the issue-3 branch October 27, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants